SDK for claiming network devices fails

SOLVED
bly
Here to help

SDK for claiming network devices fails

Using meraki-node-sdk generates a fatal error when calling DevicesController.claimNetworkDevices.

 

This appears to be because the API is specified in meraki/openapi as returning an HTTP 200 for this request, even though the actual API behaviour returns no response payload (should be HTTP 204 in that case).

 

I reported this issue back in September 2019, however it appears it has gone ignored:

https://github.com/meraki/meraki-node-sdk/issues/1

 

We have worked around this issue in the meantime by calling the API without the assistance of the SDK, can you please advise whether we should expect a fix?

 

Additionally, if you are not monitoring GitHub issues for your repositories - can you please disable them to avoid confusion?

1 ACCEPTED SOLUTION

Actually, this was already fixed in the September release! Just update your SDK to the latest version, 

 

(diff)

https://github.com/meraki/meraki-node-sdk/blob/a327f1bce7129066903ee924fd56f3c54571475e/lib/Controll...

 

Screen Shot 2020-02-04 at 2.13.20 PM.png

View solution in original post

5 REPLIES 5
BrechtSchamp
Kind of a big deal

That's not good. @DexterLaBora , is this something you can take a look at?

Thanks for bringing this up. I've responded to the issue within GitHub. 

- We are looking at fixing this from both an API and SDK perspective. 

Cheers for the reply, good to know it's on the radar 🙂

Actually, this was already fixed in the September release! Just update your SDK to the latest version, 

 

(diff)

https://github.com/meraki/meraki-node-sdk/blob/a327f1bce7129066903ee924fd56f3c54571475e/lib/Controll...

 

Screen Shot 2020-02-04 at 2.13.20 PM.png

... egg on my face - thanks for the heads up, I'll make sure we've rolled forwards to the latest version!

Get notified when there are additional replies to this discussion.